-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(formula): support lambda in function register #4298
Conversation
View Deployment
|
Playwright test resultsDetails 23 tests across 10 suites |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4298 +/- ##
==========================================
- Coverage 32.69% 32.61% -0.08%
==========================================
Files 2567 2575 +8
Lines 133268 133699 +431
Branches 29659 29740 +81
==========================================
+ Hits 43568 43602 +34
- Misses 89700 90097 +397 ☔ View full report in Codecov by Sentry. |
fde6140
to
c2e30b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me but we should add an example in the Facade API of regsitering functions.
c2e30b4
to
1e410ac
Compare
Added exmaple here https://github.com/dream-num/univer/pull/4298/files#diff-2e2ce04086a2a743f70994698013f64bfe65b0df45577523d7c3eea046ce0202R61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Wenzhao Hu <wzhudev@gmail.com>
What's updated?
Facade API registered formulas support lambda functions
How to test?
=CUSTOMSUM(1,2,LAMBDA(s,c,s+c))
, get result 6=CUSTOMSUM(A1,A2,LAMBDA(s,c,s+c))
, get result 10Pull Request Checklist