Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): support ui menu facade #4304

Merged
merged 2 commits into from
Dec 14, 2024
Merged

feat(ui): support ui menu facade #4304

merged 2 commits into from
Dec 14, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Dec 14, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 28 seconds
commit  2c50fb8
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

@wzhudev wzhudev marked this pull request as ready for review December 14, 2024 06:52
@wzhudev wzhudev requested review from jikkai and Jocs as code owners December 14, 2024 06:52
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 33.55%. Comparing base (2a01076) to head (2c50fb8).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/facade/f-menu-builder.ts 0.00% 57 Missing ⚠️
packages/ui/src/facade/f-univer.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4304      +/-   ##
==========================================
- Coverage   33.58%   33.55%   -0.04%     
==========================================
  Files        2504     2505       +1     
  Lines      129039   129100      +61     
  Branches    28891    28896       +5     
==========================================
- Hits        43335    43314      -21     
- Misses      85704    85786      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 34fc17d into dev Dec 14, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/ui-facade branch December 14, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants