Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add paste options #4393

Merged
merged 3 commits into from
Jan 8, 2025
Merged

feat: add paste options #4393

merged 3 commits into from
Jan 8, 2025

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 31, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky added the qa:untested This PR is ready to be tested label Dec 31, 2024
Copy link

github-actions bot commented Dec 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 31, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  9c6a4ad
info  For more information, see full report

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 21.89349% with 132 lines in your changes missing coverage. Please review.

Project coverage is 33.32%. Comparing base (d11553a) to head (9c6a4ad).
Report is 49 commits behind head on dev.

Files with missing lines Patch % Lines
...eets-ui/src/views/clipboard/ClipboardPopupMenu.tsx 4.59% 83 Missing ⚠️
...ing-ui/src/controllers/cf.copy-paste.controller.ts 0.00% 13 Missing ⚠️
...ets-ui/src/services/clipboard/clipboard.service.ts 56.66% 13 Missing ⚠️
packages/sheets-ui/src/components/hook.ts 0.00% 9 Missing ⚠️
...eets-ui/src/commands/commands/clipboard.command.ts 25.00% 3 Missing ⚠️
...ion-ui/src/controllers/dv-copy-paste.controller.ts 0.00% 2 Missing ⚠️
...controllers/sheet-drawing-copy-paste.controller.ts 0.00% 2 Missing ⚠️
...ui/src/controllers/formula-clipboard.controller.ts 0.00% 2 Missing ⚠️
...r-link-ui/src/controllers/copy-paste.controller.ts 0.00% 2 Missing ⚠️
.../src/controllers/clipboard/clipboard.controller.ts 87.50% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4393      +/-   ##
==========================================
- Coverage   33.35%   33.32%   -0.04%     
==========================================
  Files        2529     2530       +1     
  Lines      130387   130767     +380     
  Branches    29098    29178      +80     
==========================================
+ Hits        43493    43572      +79     
- Misses      86894    87195     +301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 2, 2025
@ybzky ybzky requested a review from wzhudev January 6, 2025 08:23
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit d758b21 into dev Jan 8, 2025
9 checks passed
@wzhudev wzhudev deleted the feat/add-optional-paste branch January 8, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants