Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): update filter facade to add events and enums #4403

Merged
merged 10 commits into from
Jan 3, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 2, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 2, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev marked this pull request as draft January 2, 2025 07:50
Copy link

github-actions bot commented Jan 2, 2025

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  09a6bc9
info  For more information, see full report

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 33.13%. Comparing base (612c981) to head (09a6bc9).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets-filter/src/facade/f-event.ts 0.00% 52 Missing ⚠️
packages/core/src/facade/f-base.ts 0.00% 11 Missing ⚠️
packages/sheets-filter/src/facade/f-enum.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4403      +/-   ##
==========================================
- Coverage   33.30%   33.13%   -0.18%     
==========================================
  Files        2532     2548      +16     
  Lines      130712   131410     +698     
  Branches    29167    29285     +118     
==========================================
+ Hits        43540    43541       +1     
- Misses      87172    87869     +697     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as ready for review January 3, 2025 02:05
@wzhudev wzhudev requested review from ybzky and yuhongz as code owners January 3, 2025 06:39
@wzhudev wzhudev merged commit 9ad9d48 into dev Jan 3, 2025
9 checks passed
@wzhudev wzhudev deleted the feat/filter-facade branch January 3, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants