Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api for ui and f-enum #4406

Merged
merged 5 commits into from
Jan 2, 2025
Merged

feat: add api for ui and f-enum #4406

merged 5 commits into from
Jan 2, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 2, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 2, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 2, 2025

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  740c4b5
info  For more information, see full report

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 33.29%. Comparing base (868e4b2) to head (740c4b5).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/facade/f-enum.ts 0.00% 14 Missing ⚠️
packages/ui/src/facade/f-univer.ts 0.00% 9 Missing ⚠️
packages/ui/src/services/parts/parts.service.ts 0.00% 8 Missing ⚠️
packages/core/src/facade/f-event.ts 0.00% 4 Missing ⚠️
...ges/ui/src/views/components/ComponentContainer.tsx 0.00% 4 Missing ⚠️
packages/sheets/src/facade/f-univer.ts 0.00% 3 Missing ⚠️
packages/ui/src/facade/f-enum.ts 0.00% 3 Missing ⚠️
packages/core/src/facade/f-univer.ts 0.00% 2 Missing ⚠️
packages/sheets/src/facade/f-event.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4406      +/-   ##
==========================================
- Coverage   33.30%   33.29%   -0.01%     
==========================================
  Files        2532     2533       +1     
  Lines      130735   130774      +39     
  Branches    29167    29169       +2     
==========================================
+ Hits        43542    43546       +4     
- Misses      87193    87228      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 51ed14e into dev Jan 2, 2025
9 checks passed
@weird94 weird94 deleted the feat/facade-core branch January 2, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants