Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): fix dropdown on nested situation #4416

Merged
merged 6 commits into from
Jan 3, 2025
Merged

fix(design): fix dropdown on nested situation #4416

merged 6 commits into from
Jan 3, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 3, 2025

close https://github.com/dream-num/univer-pro/issues/3881

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested a review from jikkai as a code owner January 3, 2025 03:26
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jan 3, 2025
@wzhudev wzhudev changed the title fix(design): fix dropdown info fix(design): fix dropdown on nested situation Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 3, 2025

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  97c6385
info  For more information, see full report

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.16%. Comparing base (c8d287b) to head (97c6385).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...esign/src/components/dropdown/DropdownProvider.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4416      +/-   ##
==========================================
- Coverage   33.27%   33.16%   -0.11%     
==========================================
  Files        2533     2546      +13     
  Lines      130854   131348     +494     
  Branches    29185    29273      +88     
==========================================
+ Hits        43536    43562      +26     
- Misses      87318    87786     +468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jan 3, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jan 3, 2025
@wzhudev wzhudev merged commit 05896c0 into dev Jan 3, 2025
9 checks passed
@wzhudev wzhudev deleted the fix/dropdown branch January 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants