Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(facade): make facade sync #4482

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(facade): make facade sync #4482

merged 2 commits into from
Jan 15, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 14, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 14, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 14, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 13 seconds
commit  94a804f
info  For more information, see full report

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 32.80%. Comparing base (f892d64) to head (94a804f).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-range.ts 0.00% 11 Missing ⚠️
...ckages/sheets-thread-comment/src/facade/f-range.ts 0.00% 6 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 2 Missing ⚠️
packages/ui/src/facade/f-univer.ts 0.00% 2 Missing ⚠️
...ges/ui/src/services/clipboard/clipboard.command.ts 0.00% 2 Missing ⚠️
...ommands/commands/remove-worksheet-merge.command.ts 0.00% 1 Missing ⚠️
...commands/commands/split-text-to-columns.command.ts 0.00% 1 Missing ⚠️
.../src/commands/commands/toggle-gridlines.command.ts 0.00% 1 Missing ⚠️
packages/sheets/src/facade/f-permission.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4482      +/-   ##
==========================================
+ Coverage   32.79%   32.80%   +0.01%     
==========================================
  Files        2582     2582              
  Lines      132924   132930       +6     
  Branches    29556    29556              
==========================================
+ Hits        43590    43611      +21     
+ Misses      89334    89319      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jan 15, 2025
@weird94 weird94 merged commit 447f991 into dev Jan 15, 2025
9 checks passed
@weird94 weird94 deleted the feat/make-facade-sync branch January 15, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants