Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): inline format optimization in render #486

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 18, 2023

  • optimization of background color render
  • optimization of text selection anchor render
  • optimization of subscript render

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e990a4e) 41.13% compared to head (3c418c2) 41.13%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #486   +/-   ##
=======================================
  Coverage   41.13%   41.13%           
=======================================
  Files         230      230           
  Lines       14223    14223           
  Branches     2870     2870           
=======================================
  Hits         5851     5851           
  Misses       7067     7067           
  Partials     1305     1305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 18, 2023

View Deployment

📝 Doc 📊 Sheet 📽️ Slide
🔗 Preview link 🔗 Preview link 🔗 Preview link

View Storybook

📚 Storybook
🔗 Preview link

@Jocs Jocs changed the title fix(doc):inline format optimization in render fix(doc):inline format optimization in render Nov 18, 2023
@Jocs Jocs changed the title fix(doc):inline format optimization in render feat(doc):inline format optimization in render Nov 18, 2023
@Jocs Jocs changed the title feat(doc):inline format optimization in render bug(doc):inline format optimization in render Nov 18, 2023
@Jocs Jocs marked this pull request as ready for review November 18, 2023 11:27
@Jocs Jocs changed the title bug(doc):inline format optimization in render bug(doc): inline format optimization in render Nov 18, 2023
@Jocs Jocs changed the title bug(doc): inline format optimization in render fix(doc): inline format optimization in render Nov 18, 2023
@wzhudev wzhudev merged commit a6d8853 into dev Nov 20, 2023
7 checks passed
@wzhudev wzhudev deleted the fix/inline-format-in-render branch November 20, 2023 06:40
Gggpound added a commit that referenced this pull request Mar 28, 2024
* feat(conditional-format): init

* feat(cf): init conditional format model

* fix(dev): fix dev config

* feat(cf):  mark dirty when change conditional rule

* feat(numfmt): support serial time  to timestamp

* feat(cf): support text number time operator

* feat(cf): add priority cache

* feat(cf): change cfid type to string from number

* fix(cf): diff value type

* feat(cf): add render highlightCell demo

* chore(cf): add condition format plugin to example

* feat(sheet): add skeleton update

* feat(cf): support average

* feat(cf): support rank

* feat(cf): support cell change and caculate cf

* feat(cf): add caculate cache

* feat(cf): supports rendering linkage

* feat(cf): do not empty style when markDirty

* feat(cf): support mix old style

* docs(cf): docs

* feat(cf): add base command and mutation

* style(cf): format

* fix(cf): can not move to the top

* feat(cf): add undo mutation

* fix(cf): reduce the cell sort time ,50%

* fix(cf): reduce the cost of mark dirty ,80%

* fix(cf): the interval contains the tail

* feat(cf): support data bar

* chore(cf): format code

* fix(cf): data bar suppoer gradient

* feat(cf): support color scale

* feat(ref-range): support default range change util

* feat(cf): conditional format support ref range

* fix(cf): some ref range bug

* feat(cf): conditional format support copy/paste

* feat(cf): support auto fill

* feat(cf): clear cf when sheet is deleted

* fix(cf): the target populated area needs to be cleared

* fix(cf): after each setting, the conditional format is cleared before rendering

* fix(cf): rule priority problem

* feat(cf): support panel set cf

* feat(cf): init menu

* feat(cf): support change priority

* chore(cf): rename

* feat(cf): support set/delete/move undo and redo

* feat(cf): add package config

* feat(cf): support i18n

* feat(cf): support preview

* fix(cf): new rules can not be retracted when added

* feat(cf): panel ui

* feat(cf): i18n support react node

* feat(cf): support t function nesting

* style(cf): ui fix

* fix(cf): serialTimeToTimestamp bugfix

* style(cf): ui fix

* feat(cf): support for persistence

* fix(cf): the node environment executes only the service logic, not the cleanup controller logic

* fix(cf): lint

* fix(cf): formula error

* feat(cf): support formula

* fix(formula): formulaId result

* fix(sheet): formula queue

* feat(formula): other formula dirty

* feat(cf): support formula mark dirty

* fix(sheet): other formula make dirty

* fix(cf): set default bg color is undefined

* feat(cf): support create rule from menu

* fix(cf): formula cache is not worke

* feat(cf): support absolute ref

* fix(formula): config service  ts error

* feat(cf): support formula value type

* feat(cf): reuse the last result before waiting for the result of the calculation

* feat(cf): menu support cf

* feat(formula): support batch register

* fix(formula): add batch interface

* feat(formula): batch remove

* fix(cf): support batch creation and deletion formulas are supported

* chore: delete obsolete file

* chore: delete obsolete file

* fix(cf): databar panel init state error

* chore(cf): extract the public code

* feat(cf): support icon set

* feat(cf): support pre build icon base64

* feat(cf): support icon set panel

* feat(cf): support range selector

* feat(cf): support formula editor

* fix(cf): error when folder does not exist

* feat(cf): iconSet support offset

* feat(cf): support clear conditional format

* fix(cf): add openForUnitId and openForSubUnitId

* feat(cf): add iconSet

* feat(cf): add icon group

* chore: extract scale color util

* feat(cf): preview support databar colorScale iconSet

* feat(cf): support set init range

* style(cf): ui fix

* fix(sheet): cf  recalculation can not be triggered when a date is involved

* fix(sheet): add form validation

* fix(cf): rangeSelector support placeholder

* feat(cf): clear menu support disabled

* feat(cf): update panel when change sheet

* chore: lint

* fix(cf): add i18n

* fix(cf): isShowValue is not work

* feat(cf): support iconSet menu

* fix(cf): init error

* test(cf): add highlight test case

* chore(cf): add type and doc

* chore(debugger): add sheet snapshot util

* style(cf): change default color

* test(cf): add colorscale and databar test case

* fix(cf): optimize dirty logic (#433)

* fix(cf): when previewing a number format, the conditional format style does not take effect (#439)

* fix(cf): fix checkbox error

* fix(cf): add databar min width

* fix(cf): ignore rich text

* fix(cf): some interceptors block subsequent logic execution

* fix(cf): support contains blanks

* feat(cf): support today

* fix(cf): reset formula

* wait

* fix(cf): filter abnormal settings

* fix(cf): can not modify icon set settings

* fix(cf): icon set support formula

* fix(cf): fix formula edit style

* fix(cf): verify not work when iconSet switch valueType

* fix(cf): iconset verify support formula

* fix(cf): duplicate and unique not work with p (#495)

* fix(cf): paste only the content without conditional formatting rules (#489)

* fix(cf): compose bius config (#487)

* fix(cf): different styles of icon set render different results (#485)

* fix(cf): the icon set should be above the data bar (#483)

* fix(cf): the warning prompt is in the wrong position (#480)

* fix(cf): the settings for filtering errors (#475)

* fix(cf): 0 can not be set (#472)

* fix(cf): error highlighting result of custom formula (#468)

* fix(cf): numerical calculations add type checking (#458)

* feat(cf): support clear (#433)

* feat(cf): select changes to update the rules panel(#437)

* fix(cf): 0 can not be set (#446)

* fix(cf): the style of the filter condition format is set after editing (#486)

* feat(cf): data bar gradient color adds border

* feat(cf): formula support absolute ref

* fix(cf): rule list panel were not updated in a timely manner (#437)

* feat(cf): number compare support mixed max and min

* feat(cf): support boolean compare (#461)

* fix(cf): add input validation (#454)

* feat(cf): zenZone hide cf

* fix(cf): error message does not disappear after update the icon set configuration(#480)

* test(core): add test case

* style(cf): enum should have prefix

* fix(ui): do not use hook use if logic

* style(cf): rename

* test(cf): add color scale test case

* fix(cf): not between support mixed max and min

* feat(cf): support empty icon

* style(cf): ui

---------

Co-authored-by: DR-Univer <wbfsa@qq.com>
Co-authored-by: Dushusir <1414556676@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants