Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid double-including src when excludeAppGlideModule = true #124

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

kibiz0r
Copy link
Contributor

@kibiz0r kibiz0r commented Nov 11, 2024

Looks like #37 accidentally broke excludeAppGlideModule

Copy link

🚀 Thanks for your first Pull Request!
Your contribution is greatly appreciated, and a maintainer will review it soon.
Meanwhile, feel free to check out other issues or share your thoughts on the project.
We’re excited to have you on board! 🎉

@princektripathi
Copy link
Contributor

Looks like #37 accidentally broke excludeAppGlideModule

@kibiz0r, thanks for raising the PR. Can you please share a repro to validate ?

@princektripathi princektripathi added the Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) label Nov 15, 2024
@kibiz0r
Copy link
Contributor Author

kibiz0r commented Nov 19, 2024

@princektripathi Here's a repro: https://github.com/kibiz0r/ReactNativeFastImageIssue124Repro

npm run android

ReactNativeFastImageIssue124Repro/node_modules/@d11/react-native-fast-image/android/src/oldarch/java/com/FastImageViewModule.java:17: error: duplicate class: com.dylanvann.fastimage.FastImageViewModule
class FastImageViewModule extends ReactContextBaseJavaModule {
^
ReactNativeFastImageIssue124Repro/node_modules/@d11/react-native-fast-image/android/src/oldarch/java/com/FastImageViewManager.java:36: error: duplicate class: com.dylanvann.fastimage.FastImageViewManager
class FastImageViewManager extends SimpleViewManager<FastImageViewWithUrl> implements FastImageProgressListener {
^

@princektripathi
Copy link
Contributor

@princektripathi Here's a repro: https://github.com/kibiz0r/ReactNativeFastImageIssue124Repro

npm run android

ReactNativeFastImageIssue124Repro/node_modules/@d11/react-native-fast-image/android/src/oldarch/java/com/FastImageViewModule.java:17: error: duplicate class: com.dylanvann.fastimage.FastImageViewModule
class FastImageViewModule extends ReactContextBaseJavaModule {
^
ReactNativeFastImageIssue124Repro/node_modules/@d11/react-native-fast-image/android/src/oldarch/java/com/FastImageViewManager.java:36: error: duplicate class: com.dylanvann.fastimage.FastImageViewManager
class FastImageViewManager extends SimpleViewManager<FastImageViewWithUrl> implements FastImageProgressListener {
^

@kibiz0r, thanks for the repro. I'll review and get back to you.

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2024

CLA assistant check
All committers have signed the CLA.

@princektripathi
Copy link
Contributor

@kibiz0r, thanks for your contribution to the repo. CLA has to be signed to merge the PR. Can you please sign it?

@kibiz0r
Copy link
Contributor Author

kibiz0r commented Dec 19, 2024

@princektripathi Done!

@princektripathi princektripathi requested review from princektripathi and sarthak-d11 and removed request for sarthak-d11 December 20, 2024 08:07
@sarthak-d11 sarthak-d11 merged commit 8e9cda4 into dream-sports-labs:main Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First PR Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants