Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC-002: Login email flow #4

Merged
merged 1 commit into from
Feb 8, 2024
Merged

EC-002: Login email flow #4

merged 1 commit into from
Feb 8, 2024

Conversation

angeloreale
Copy link
Contributor

@angeloreale angeloreale commented Feb 8, 2024

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

EC-002

Just a quick update for email flow.

Screenshots/Videocasts/Preview Links

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added screenshots? (if relevant)
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

Copy link
Contributor Author

@angeloreale angeloreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angeloreale
Copy link
Contributor Author

nit: not sure whether the email server / email server request is working correctly, but i'm sure they payload for email signup is correct now.

@angeloreale angeloreale merged commit 8a1ad8a into dev Feb 8, 2024
3 checks passed
@angeloreale angeloreale deleted the ar/login-flow branch February 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant