Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ar(fix) DPCP-121: Locale Parsing #48

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

angeloreale
Copy link
Contributor

PLEASE REVIEW YOUR OWN PR BEFORE OPENING/UN-DRAFTING IT

[Ticket Title]

[ticket description]

Screenshots/Videocasts/Preview Links

Have you?

  • Reviewed your own PR?
  • Tested your own feature/fix meets Acceptance Criteria?
  • Made sure it passes all checks? (lint, build, integrations, scripts, etc)?
  • Added screenshots? (if relevant)
  • Added unit tests? (if necessary)
  • Added documentation? (if necessary)

If so, THANKS! You can pop a beer/soda.

Please open your PR and ping your colleagues to review it on #web-devs channel.

Also, make sure to remind them on a daily basis during stand-up.

Copy link

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nyx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 2:29pm

Copy link
Contributor Author

@angeloreale angeloreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 congrats, that's a lot of code. helps a lot of people.

@angeloreale angeloreale merged commit 021c328 into dev Aug 30, 2024
5 of 6 checks passed
@angeloreale angeloreale deleted the ar/fix/dpcp-121--locale-fix branch August 30, 2024 14:29
@angeloreale angeloreale mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant