-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a conda
install option for pytorch-tabnet
#346
Comments
|
Nice work :) |
Is there anything for us to do, to maintain this ? |
@Hartorn It will be nice if you could nominate someone (you or someone of your choice who could be a comaintainer with me of the conda-forge feedstock that maintains the package on conda-forge channel. So, who do you propose? |
@sugatoray You can add @Optimox @Hartorn @eduardocarvp also, but, not sure I will have time to do this honestly I guess @Optimox is the more active here. |
@Hartorn Yes, there is a PR (#347) that I raised. If you could take a look at it and merge it, that will be great. For long term maintainability, I will add @Optimox @Hartorn @eduardocarvp to the feedstock and walk you through the easy simple steps you need to do after each PyPI release you make. This will enable you to keep both PyPI and conda-forge versions in sync. As a co-maintainer, obviously, if you have questions, I will be there. Sounds good? |
Any idea, when your next release could be scheduled? |
I think we need to update the release script then, to include those steps in it
@Optimox Any idea ? |
@Hartorn Here is the ⭐LinkedIn share on making |
Nice work :) #347 looks good to me as well, just got to reword your commit in order to comply to conventional commits. We just have to merge #348 and then we will probably make a release as soon as it's done. I see no problem on merging #347 as well before the next release. So to give a proper answer, probably next week for the next release. I would be super down to look into the steps after the PyPI release to keep both projects in sync, do you have access to the project Slack, @sugatoray ? We can talk over there and would be great if we could include all we need on our release scripts. |
updated readme with conda-install-instruction - added conda install instruction - added relevant badges Closes issue dreamquark-ai#346
Yes. Just joined. Didn't realize that you had reworded the commit message. I also reworded that. |
Thanks @sugatoray, Very nice contribution as a lot of people use conda! As @Hartorn suggested, I think we should somehow automate the push to conda so that we do not have to think twice when making a new release. About the date of the next release, it should be fairly soon, we could aim to release before the end of the year. |
Well, conda-forge already has some automation in place. It's not a best practice in conda-forge to completely automate this. It's in fact, much simpler a step, and should be thoroughly checked before pushing to conda-forge. You don't automatically merge without reviewing here, right? What I would suggest you is to send a PR to If you must automate, you can automate on your end here. But the PR review at conda-forge must remain a manual step. All you have to do is update the file: Change:
So, if you would like to write a script that would create the A few key things to remember, if you want some automation on your end (in this repo):
|
@sugatoray yes I guess we would like to automate as much as possible. With poetry we are actually just automatically pushing the changes to pypi when we make a release, which is much simpler. But I guess it should not be a problem to remember to push on conda as long as it's not too difficult. |
@Optimox I understand the reason behind why you want to automate as much as possible: reduce technical debt. I am personally a heavy supporter of automation. Let me know if you need any help with that. |
updated readme with conda-install-instruction - added conda install instruction - added relevant badges Closes issue #346
Feature request
A
conda
installation option could be quite helpful as an alternative alongside the ability to installpytorch-tabnet
withpip
. I have already done the work necessary to makepytorch-tabnet
available onconda-forge
. (PR: conda-forge/staged-recipes#17292)Now you can install
pytorch-tabnet
as:💡 I will send a PR to update the docs/readme.
The text was updated successfully, but these errors were encountered: