Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake vars for module discovery and install #110

Open
wants to merge 1 commit into
base: release
Choose a base branch
from

Conversation

YakoYakoYokuYoku
Copy link

Fixes issues with erroneous discovery of Moonray dependencies.

Namely, if the first directory of $PATH is set to /bin then /bin, /lib and /include would be used as search paths.

-- Found Boost: /lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0") found components: chrono date_time filesystem program_options system 
-- Found Boost: /lib/cmake/Boost-1.81.0/BoostConfig.cmake (found version "1.81.0") found components: chrono date_time filesystem program_options 
-- Found Python: /bin/python3.11 (found version "3.11.3") found components: Interpreter

But /include doesn't exist in your standard Linux install, so CMake is going to look at the wrong place if it were to look for headers.

Also this PR uses list(PREPEND ...) with CMAKE_MODULE_PATH so that it considers project paths first and CMAKE_INSTALL_PREFIX is assigned to the default value of release if unset.

Prepend to lists so that local CMake modules are considered first.
Set install prefix when adecuate.
Modify `$PATH` only if `$CUDAToolkit_ROOT` is set.
@jlanz
Copy link
Contributor

jlanz commented Jul 14, 2023

Thank you for submitting a Pull Request. Developers who wish to contribute code to be considered for inclusion in MoonRay must first complete a Contributor License Agreement, and email it to MoonRay@dreamworks.com and be sure to include your GitHub username(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants