DX-23332: Add method to parse date from null-terminated string #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projjal
commented
Jun 11, 2020
cpp/src/arrow/util/value_parsing.h
Outdated
| @@ -561,6 +562,38 @@ static inline bool ParseTimestampStrptime(const char* buf, size_t length, | |||
| return true; | |||
| } | |||
|
|
|||
| /// \brief Returns time since the UNIX epoch in the requested unit. Takes null terminated | |||
| /// buffer as argument | |||
| static inline bool ParseTimestampStrptime(const char* buf, | |||
There was a problem hiding this comment.
Line 533 contains the original function that takes non null-terminated string as argument.
pprudhvi
reviewed
Jun 11, 2020
cpp/src/arrow/util/value_parsing.h
Outdated
| @@ -23,6 +23,7 @@ | |||
| #include <chrono> | |||
| #include <cstddef> | |||
| #include <cstdint> | |||
| #include <cstring> | |||
There was a problem hiding this comment.
for the strlen function in L582
|
LGTM |
pravindra
reviewed
Jun 11, 2020
pravindra
approved these changes
Jun 11, 2020
projjal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.