Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-61115: [C++] Update fast_float version to 3.10.1 (#36434) #35

Merged
merged 1 commit into from
Jul 24, 2023
Merged

DX-61115: [C++] Update fast_float version to 3.10.1 (#36434) #35

merged 1 commit into from
Jul 24, 2023

Conversation

xxlaykxx
Copy link

Rationale for this change

Need this for parsing Infinity values with + sign.

What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

Are these changes tested?

in scope of fast_float.

Are there any user-facing changes?

no

Lead-authored-by: Ivan Chesnov ivan.chesnov@dremio.com

### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>
Co-authored-by: Ivan Chesnov <xxxlaykxxx@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@xxlaykxx xxlaykxx merged commit cddcd3b into dremio:dremio_24.3_13.0 Jul 24, 2023
10 checks passed
lriggs pushed a commit that referenced this pull request Jul 28, 2023
…) (#35)

### Rationale for this change

Need this for parsing Infinity values with + sign.

### What changes are included in this PR?

updated version of fast_float to version 3.10.1 (used this version because in higher versions c++ 20 started using that cause a lot of build errors)

### Are these changes tested?
 
in scope of fast_float.

### Are there any user-facing changes?
no

* Closes: apache#36433

Lead-authored-by: Ivan Chesnov <ivan.chesnov@dremio.com>

Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant