Skip to content

GH-87: [Vector] Add ExtensionWriter (apache#697) #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xxlaykxx merged 2 commits into from
Jun 27, 2025
+3 −4
Merged

GH-87: [Vector] Add ExtensionWriter (apache#697) #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a4819
GH-87: [Vector] Add ExtensionWriter (apache#697)
xxlaykxx Jun 26, 2025
e8e5ff1
GH-87: [Vector] Add ExtensionWriter (apache#697)
xxlaykxx Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java/vector/src/main/codegen/templates/AbstractPromotableFieldWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public MapWriter map(boolean keysSorted) {

@Override
public ExtensionWriter extension(ArrowType arrowType) {
return getWriter(MinorType.EXTENSIONTYPE).extension(arrowType);
return getWriter(MinorType.LIST).extension(arrowType);
}

@Override
Expand Down Expand Up @@ -325,7 +325,7 @@ public MapWriter map(String name, boolean keysSorted) {

@Override
public ExtensionWriter extension(String name, ArrowType arrowType) {
return getWriter(MinorType.EXTENSIONTYPE).extension(name, arrowType);
return getWriter(MinorType.STRUCT).extension(name, arrowType);
}

<#list vv.types as type><#list type.minor as minor>
Expand Down
3 changes: 1 addition & 2 deletions java/vector/src/main/codegen/templates/UnionListWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,7 @@ public MapWriter map(String name, boolean keysSorted) {

@Override
public ExtensionWriter extension(ArrowType arrowType) {
writer.extension(arrowType);
return writer;
return this;
}

@Override
Expand Down
Loading