Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parentheses from create view logic #172

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Remove parentheses from create view logic #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f3ea03
remove parentheses from create view logic
ravjotbrar Apr 4, 2023
d5b7b6b
add changelog
ravjotbrar Apr 5, 2023
5f75e4f
change from fix to under the hood
ravjotbrar Apr 5, 2023
3a24162
Merge branch 'main' into test-branch
ravjotbrar Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,17 @@
## Under the Hood

- [#199](https://github.com/dremio/dbt-dremio/issues/199) Populate PyPI's `long_description` with contents of `README.md`
- [#167](https://github.com/dremio/dbt-dremio/issues/167) Remove parentheses surrounding views in the create_view_as macro. In more complex queries, the parentheses cause performance issues.


# dbt-dremio 1.5.0 - release June 22, 2023


## Features

## Fixes

## Under the Hood

- [#179](https://github.com/dremio/dbt-dremio/issues/179) Upgrade to support dbt-core v1.5.0.
- Add support for Python 3.11.
- Add support for relevant Tests:
Expand All @@ -27,6 +29,7 @@
- Upgrade dbt-tests-adapter to 1.5.0.
- Upgrade Requests to 2.31.0. [#183](https://github.com/dremio/dbt-dremio/issues/183).


# dbt-dremio 1.4.5 - release March 23, 2023

## Features
Expand Down
5 changes: 2 additions & 3 deletions dbt/include/dremio/macros/materializations/view/create_view_as.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ limitations under the License.*/

{{ sql_header if sql_header is not none }}

create or replace view {{ relation }} as (
{{ sql }}
)
create or replace view {{ relation }} as {{ sql }}

{%- endmacro %}