-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stack overflow #190
Fix stack overflow #190
Conversation
26f7c82
to
d361bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you updated PanasonicRawWbInfo2Descriptor as well. You might do the same thing on the Java side before approving that one.
But on the dotnet side, this all seems reasonable.
👋 Hi @drewnoakes @kwhopper I'm a member of the GitHub software security team. |
Hi, |
Version 2.2.0 is released which includes this fix along with several other improvements. |
Thank you - no more security alerts from the GitHub then 😀 |
@drewnoakes hello - I am looking for a non-dotnet version of this library that contains the same whitesource vulnerability fix. I see that the dotnet version with the fix is 2.2.0, dated 27 Oct 2019. Am I right in assuming that non-dotnet versions 2.12.0 (6 Jul 2019) and 2.13.0 (21 Jan 2020) contain the same fix? Thanks, Philip |
@philipjss I assume you're referring to the Java implementation. For that library, version 2.13.0 contains the stack overflow fix. https://github.com/drewnoakes/metadata-extractor/releases/tag/2.13.0 |
…ility scrimage currently uses metadata-extractor 2.12.0, which suffers from a stackoverflow vulnerability (see drewnoakes/metadata-extractor-dotnet#190 for details - in the dotnet version of metadata-extractor) The vulnerability is fixed in version 2.13.0 of metadata-extractor (see drewnoakes/metadata-extractor-dotnet#190 (comment)). Can we please upgrade to metadata-extractor 2.13.0?
…ility scrimage currently uses metadata-extractor 2.12.0, which suffers from a stackoverflow vulnerability (see drewnoakes/metadata-extractor-dotnet#190 for details - in the dotnet version of metadata-extractor) The vulnerability is fixed in version 2.13.0 of metadata-extractor (see drewnoakes/metadata-extractor-dotnet#190 (comment)). Can we please upgrade to metadata-extractor 2.13.0?
Fixes the .NET side of drewnoakes/metadata-extractor#419.