Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow envelope sender override per message #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sumbach
Copy link
Contributor

@sumbach sumbach commented Mar 29, 2014

Work in progress

This is just a failing test demonstrating the behavior I'd like to see. There is currently some inconsistency between sendmail and smtp transports:

  • sendmail transport: Envelope sender can be specified on a per-message basis with the :sender key.
  • smtp transport: Envelope sender can be specified with :sender key in server param to send-message. The :sender key in msg is used as the From address, but it's not possible to set SMTP envelope sender separately from the From address.

Ideally, the :sender key could be used to set the SMTP envelope sender for both the smtp and sendmail transports. To make this happen, we will need to create a new Session instance for each message with a :sender key.

What do you think?

@sumbach sumbach changed the title Failing test for allowing envelope sender override per message Allowing envelope sender override per message Mar 29, 2014
@sumbach sumbach changed the title Allowing envelope sender override per message Allow envelope sender override per message Mar 29, 2014
@jeremyheiler
Copy link

I don't have commit rights, but this makes sense to me.

@drewr drewr force-pushed the master branch 4 times, most recently from b199c5a to 382cb0e Compare November 18, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants