Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-v/--version #11

Merged
merged 1 commit into from
Apr 25, 2019
Merged

-v/--version #11

merged 1 commit into from
Apr 25, 2019

Conversation

drewwyatt
Copy link
Owner

@drewwyatt drewwyatt commented Apr 24, 2019 •
edited
Loading

Resolves issue #8

Luckily, goreleaser is already linking a version variable at build time - all we had to do is hook it up.

@drewwyatt drewwyatt added this to the 0.3.0 milestone Apr 24, 2019
daltonclaybrook
daltonclaybrook approved these changes Apr 25, 2019
View reviewed changes
Copy link
Collaborator

@daltonclaybrook daltonclaybrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I know this probably isn't going to grow much larger, but as more commands are added, it might make sense to break these out into some kind of discrete Command object/enum and fork the code paths by switching on this.

@drewwyatt drewwyatt merged commit 62b8338 into master Apr 25, 2019
@drewwyatt drewwyatt deleted the dw/version branch April 25, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonclaybrook daltonclaybrook daltonclaybrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@drewwyatt @daltonclaybrook