Allow directory to be provided as final arg #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Git now has a constructor that takes a directory - Directory is used for every command executed by execGitCommand
Merged
daltonclaybrook
approved these changes
Apr 26, 2019
| } | ||
|
|
||
| // NewExecutor Constructor for git executor | ||
| func NewExecutor(directory string) Git { |
Collaborator
There was a problem hiding this comment.
Is it weird that this returns a Git, but your other functions take/return a *Git?
Owner
Author
There was a problem hiding this comment.
I actually tried returning a *Git first, and the compiler complained.
The way I have come to understand this is that NewExecutor returns a Git, because it is creating a new instance that isn't yet being referenced anywhere? (this may be flawed reasoning)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execGitCommandflag.Arg(0)to new Git constructor inmain