fix issue #14, issue #20 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 9, 2020
Closed
|
Thanks for working on this. I will need some time to review and merge as I am preoccupied with some other work. Will try to get back to you by next week |
|
No worries! Take your time. Let me know if there is anything I can do |
drgn-hart
requested changes
Oct 12, 2020
src/core/timer.js
Outdated
| @@ -22,6 +31,7 @@ chrome.runtime.onMessage.addListener( | |||
| * @param {Number} seconds - seconds for which timer should run | |||
| */ | |||
| function startTimer(hours, minutes, seconds) { | |||
| debugger; | |||
There was a problem hiding this comment.
Thank you for checking my code. Sorry about leaving the debugger. I've removed it and pushed the change.
drgn-hart
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added the pause and resume feature to the extension. Please let me know if there is anything you want me to modify, including coding style and UI.
Also, I add one setting of the font color during the rand of 5-10 minutes. I set it to black to improve accessibility.