Skip to content

Commit

Permalink
[CI] Update Hexagon image to install boost (apache#12613)
Browse files Browse the repository at this point in the history
The new image has xgboost installed, which I need for apache#12587

Validated in https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/279/pipeline
  • Loading branch information
masahi authored and driazati committed Aug 26, 2022
1 parent 7f1856d commit bc0fab2
Show file tree
Hide file tree
Showing 36 changed files with 31 additions and 25 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/flaky-test.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ labels: "test: flaky"

Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking. You are always welcomed to post on the forum first :smile_cat:

These tests were found to be flaky (intermittently failing on `main` or failed in a PR with unrelated changes). As per [the docs](https://github.com/apache/tvm/blob/main/docs/contribute/ci.rst#handling-flaky-failures, these failures will be disabled in a PR that references this issue until the test owners can fix the source of the flakiness.
These tests were found to be flaky (intermittently failing on `main` or failed in a PR with unrelated changes). As per [the docs](https://github.com/apache/tvm/blob/main/docs/contribute/ci.rst#handling-flaky-failures), these failures will be disabled in a PR that references this issue until the test owners can fix the source of the flakiness.

### Test(s)

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cc_bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -eux
python tests/scripts/github_cc_reviewers.py || echo step failed
python ci/scripts/github_cc_reviewers.py || echo step failed
2 changes: 1 addition & 1 deletion .github/workflows/docs_bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -eux
python tests/scripts/github_docs_comment.py
python ci/scripts/github_docs_comment.py
2 changes: 1 addition & 1 deletion .github/workflows/nightly_docker_update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -eux
python tests/scripts/open_docker_update_pr.py
python ci/scripts/open_docker_update_pr.py
2 changes: 1 addition & 1 deletion .github/workflows/ping_reviewers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -eux
python tests/scripts/ping_reviewers.py --wait-time-minutes 10080 || echo failed
python ci/scripts/ping_reviewers.py --wait-time-minutes 10080 || echo failed
2 changes: 1 addition & 1 deletion .github/workflows/tag_teams.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -eux
python tests/scripts/github_tag_teams.py || echo failed
python ci/scripts/github_tag_teams.py || echo failed
2 changes: 1 addition & 1 deletion .github/workflows/tests_bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -eux
python tests/scripts/github_skipped_tests_comment.py
python ci/scripts/github_skipped_tests_comment.py
2 changes: 1 addition & 1 deletion .github/workflows/tvmbot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
run: |
set -eux
python tests/scripts/github_tvmbot.py --pr "$PR_NUMBER" --run-url "$RUN_URL" --trigger-comment-json "$ISSUE_COMMENT"
python ci/scripts/github_tvmbot.py --pr "$PR_NUMBER" --run-url "$RUN_URL" --trigger-comment-json "$ISSUE_COMMENT"
2 changes: 1 addition & 1 deletion .github/workflows/update_last_successful_branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -eux
python tests/scripts/update_branch.py || echo step failed
python ci/scripts/update_branch.py || echo step failed
14 changes: 7 additions & 7 deletions Jenkinsfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ TVM project in a healthy state and preventing breakages. CI in TVM is broken int
- The tests themselves, all of which live underneath [`tests`](../tests).
- Definitions of test suites, with each suite defined as a separate `task_` script in
[`tests/scripts`](../tests/scripts).
- Scripts and automation [`ci/scripts`](../ci/scripts).
- The linux test sequence (in [`Jenkinsfile`](../Jenkinsfile)), which lints and builds TVM and runs test
suites using Docker on Linux.
- The Windows and Mac test sequences (in [`.github/actions`](../.github/actions)).
Expand Down
12 changes: 6 additions & 6 deletions ci/jenkins/Prepare.groovy.j2
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def should_skip_slow_tests(pr_number) {
// Exit code of 1 means run slow tests, exit code of 0 means skip slow tests
result = sh (
returnStatus: true,
script: "./tests/scripts/should_run_slow_tests.py --pr '${pr_number}'",
script: "./ci/scripts/should_run_slow_tests.py --pr '${pr_number}'",
label: 'Check if CI should run slow tests',
)
}
Expand All @@ -105,7 +105,7 @@ def should_skip_ci(pr_number) {
}
glob_skip_ci_code = sh (
returnStatus: true,
script: "./tests/scripts/git_skip_ci_globs.py",
script: "./ci/scripts/git_skip_ci_globs.py",
label: 'Check if CI should be skipped due to changed files',
)
if (glob_skip_ci_code == 0) {
Expand All @@ -119,7 +119,7 @@ def should_skip_ci(pr_number) {
// full CI just in case). Exit code of 0 means skip CI.
git_skip_ci_code = sh (
returnStatus: true,
script: "./tests/scripts/git_skip_ci.py --pr '${pr_number}'",
script: "./ci/scripts/git_skip_ci.py --pr '${pr_number}'",
label: 'Check if CI should be skipped',
)
}
Expand All @@ -134,7 +134,7 @@ def prepare() {

if (env.DETERMINE_DOCKER_IMAGES == 'yes') {
sh(
script: "./tests/scripts/determine_docker_images.py {% for image in images %}{{ image.name }}={% raw %}${{% endraw %}{{ image.name }}{% raw %}}{% endraw %} {% endfor %}",
script: "./ci/scripts/determine_docker_images.py {% for image in images %}{{ image.name }}={% raw %}${{% endraw %}{{ image.name }}{% raw %}}{% endraw %} {% endfor %}",
label: 'Decide whether to use tlcpack or tlcpackstaging for Docker images',
)
// Pull image names from the results of should_rebuild_docker.py
Expand All @@ -160,14 +160,14 @@ def prepare() {

is_docs_only_build = sh (
returnStatus: true,
script: './tests/scripts/git_change_docs.sh',
script: './ci/scripts/git_change_docs.sh',
label: 'Check for docs only changes',
)
skip_ci = should_skip_ci(env.CHANGE_ID)
skip_slow_tests = should_skip_slow_tests(env.CHANGE_ID)
rebuild_docker_images = sh (
returnStatus: true,
script: './tests/scripts/git_change_docker.sh',
script: './ci/scripts/git_change_docker.sh',
label: 'Check for any docker changes',
)

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docker/bash.sh
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ if [ -n "${EXPANDED_SHORTCUT}" ]; then
if [ "${CI+x}" == "x" ]; then
DOCKER_IMAGE_NAME="${EXPANDED_SHORTCUT}"
else
python3 tests/scripts/determine_docker_images.py "$DOCKER_IMAGE_NAME=$EXPANDED_SHORTCUT" 2> /dev/null
python3 ci/scripts/determine_docker_images.py "$DOCKER_IMAGE_NAME=$EXPANDED_SHORTCUT" 2> /dev/null
DOCKER_IMAGE_NAME=$(cat ".docker-image-names/$DOCKER_IMAGE_NAME")
if [[ "$DOCKER_IMAGE_NAME" == *"tlcpackstaging"* ]]; then
echo "WARNING: resolved docker image to fallback tag in tlcpackstaging" >&2
Expand Down
2 changes: 1 addition & 1 deletion tests/scripts/setup-pytest-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function cleanup() {
set +x
if [ "${#pytest_errors[@]}" -gt 0 ]; then
echo "These pytest invocations failed, the results can be found in the Jenkins 'Tests' tab or by scrolling up through the raw logs here."
python3 tests/scripts/pytest_wrapper.py "${pytest_errors[@]}"
python3 ci/scripts/pytest_wrapper.py "${pytest_errors[@]}"
exit 1
fi
set -x
Expand Down
5 changes: 5 additions & 0 deletions tests/scripts/task_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,14 @@
import shutil
import os
import logging
import sys
import multiprocessing

from pathlib import Path

# Hackery to enable importing of utils from ci/scripts
REPO_ROOT = Path(__file__).resolve().parent.parent.parent
sys.path.append(str(REPO_ROOT / "ci" / "scripts"))
from cmd_utils import Sh, init_log, REPO_ROOT


Expand Down
2 changes: 1 addition & 1 deletion tests/scripts/task_python_frontend.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ run_pytest cython python-frontend-pytorch tests/python/frontend/pytorch

echo "Running relay Tensorflow frontend test..."
# Note: Tensorflow tests often have memory issues, so invoke each one separately
TENSORFLOW_TESTS=$(./tests/scripts/pytest_ids.py --folder tests/python/frontend/tensorflow)
TENSORFLOW_TESTS=$(./ci/scripts/pytest_ids.py --folder tests/python/frontend/tensorflow)
i=0
for node_id in $TENSORFLOW_TESTS; do
echo "$node_id"
Expand Down

0 comments on commit bc0fab2

Please sign in to comment.