Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auction.py #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update auction.py #206

wants to merge 1 commit into from

Conversation

KhalidMustafin
Copy link
Contributor

  1. Type annotations have been added for all functions.
  2. Simplified logic in the functions get_auction_price_for_fixed_auction and get_auction_price_for_oracle_offset_auction using a direction multiplier.
  3. F-strings are used for formatting error messages.
  4. Added a MARKET_ORDERS constant for frequently used string values.
  5. Added docstrings to all functions.
  6. Slightly optimized the code structure for better readability.

@KhalidMustafin
Update auction.py
e239dd5 
1. Type annotations have been added for all functions.
2. Simplified logic in the functions get_auction_price_for_fixed_auction and get_auction_price_for_oracle_offset_auction using a direction multiplier.
3. F-strings are used for formatting error messages.
4. Added a MARKET_ORDERS constant for frequently used string values.
5. Added docstrings to all functions.
6. Slightly optimized the code structure for better readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KhalidMustafin