program: allow limit orders to have explicit zero auction duration pa…

…ssed in params (#373)

* program: dont enforce min auction for limit orders

* still force limit orders to have min auction duration

* add comment

* CHANGELOG

CHANGELOG.md

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixes
 
 - ts-sdk: fix resolvePerpBankrupcty to work with all perp market indexes
+- program: allow limit orders to have explicit zero auction duration passed in params ([#373](https://github.com/drift-labs/protocol-v2/pull/373))
 
 ### Breaking
 

programs/drift/src/controller/orders.rs

@@ -382,20 +382,30 @@ fn get_auction_params(
         return Ok((0_i64, 0_i64, 0_u8));
     }
 
-    let auction_duration = params
-        .auction_duration
-        .unwrap_or(0)
-        .max(min_auction_duration);
-
     if params.order_type == OrderType::Limit {
-        return match (params.auction_start_price, params.auction_end_price) {
-            (Some(auction_start_price), Some(auction_end_price)) => {
+        return match (
+            params.auction_start_price,
+            params.auction_end_price,
+            params.auction_duration,
+        ) {
+            (Some(auction_start_price), Some(auction_end_price), Some(auction_duration)) => {
+                let auction_duration = if auction_duration == 0 {
+                    auction_duration
+                } else {
+                    // if auction is non-zero, force it to be at least min_auction_duration
+                    auction_duration.min(min_auction_duration)
+                };
                 Ok((auction_start_price, auction_end_price, auction_duration))
             }
             _ => Ok((0_i64, 0_i64, 0_u8)),
         };
     }
 
+    let auction_duration = params
+        .auction_duration
+        .unwrap_or(0)
+        .max(min_auction_duration);
+
     let (auction_start_price, auction_end_price) =
         match (params.auction_start_price, params.auction_end_price) {
             (Some(auction_start_price), Some(auction_end_price)) => {

programs/drift/src/validation/order.rs

@@ -211,6 +211,18 @@ fn validate_limit_order_auction_params(order: &Order) -> DriftResult {
         )?;
 
         validate_auction_params(order)?;
+    } else {
+        validate!(
+            order.auction_start_price == 0,
+            ErrorCode::InvalidOrder,
+            "limit order without auction can not have an auction start price"
+        )?;
+
+        validate!(
+            order.auction_end_price == 0,
+            ErrorCode::InvalidOrder,
+            "limit order without auction can not have an auction end price"
+        )?;
     }
 
     Ok(())