program: more leniency in allowing risk decreasing trades for perps #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crispheaney
commented
Dec 17, 2022
•
crispheaney
commented
- for risk decreasing trades, dont use maintenance buffer ratio when calculating leverage
- dont check maker maintenance ratio if they weren't filled
crispheaney
commented
Dec 17, 2022
| )?; | ||
|
|
||
| if !risk_decreasing && market_is_reduce_only { | ||
| cancel_risk_increasing_order( |
There was a problem hiding this comment.
when market if reduce only, we force all orders to be reduce_only. and we already check to cancel reduce only orders elsewhere, so this was redundant now
There was a problem hiding this comment.
so even if a risk increasing limit order was placed prior to the market becoming reduce only, it will cancel still?
There was a problem hiding this comment.
no it would still be able to increase the position
There was a problem hiding this comment.
we can add this back else where
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.