program: new modify order ix #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbigz
reviewed
Apr 11, 2023
| let post_only = modify_order_params | ||
| .post_only | ||
| .unwrap_or(if existing_order.post_only { | ||
| PostOnlyParam::MustPostOnly |
There was a problem hiding this comment.
good to have stricter assumption here 👍
0xbigz
reviewed
Apr 11, 2023
| } else { | ||
| PostOnlyParam::None | ||
| }); | ||
| let immediate_or_cancel = modify_order_params |
There was a problem hiding this comment.
technically, params.immediate_or_cancel should not be allowed here, right? looking at handle_place_perp_order
There was a problem hiding this comment.
yeah it should only be false
0xbigz
reviewed
Apr 11, 2023
| let user_order_id = existing_order.user_order_id; | ||
| let base_asset_amount = modify_order_params | ||
| .base_asset_amount | ||
| .unwrap_or(existing_order.base_asset_amount); |
There was a problem hiding this comment.
should this enforce that a partially filled order (base_asset_amount_filled!=0) must have the base asset amount replaced?
might be nice not to and havent thought it completely thru, but just wondering if this is going to lead to confusing states (quoteAssetAmountFilled estimating prices etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.