-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement file scheme #404
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
======================================
Coverage 94.0% 94.0%
======================================
Files 22 23 +1
Lines 1619 1637 +18
======================================
+ Hits 1522 1540 +18
Misses 97 97
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we correctly handle percent-encoded colons from a drive on Windows? e.g.,
file://c:/path/to/file.txt
vs. file://c%3A/path/to/file.txt
We should at least have a test for it.
See this PR AcademySoftwareFoundation/OpenTimelineIO#1664
that also referenced the cpython issue that you took this implementation from. They discuss the issue in that PR and have a Windows test case.
I tried to search around, and I found this which suggests that the percent-encoded version should be considered valid: https://github.com/microsoft/language-server-protocol/pull/1786/files
Updated, thanks @jayqi! |
Simple implementation of
file:
scheme inAnyPath
.Uses implementation from here, but it looks like there is a
from_uri
method coming topathlib
in 3.13.Closes #401