Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source which virtualenvwrapper.sh from Makefile #205

Closed
wants to merge 1 commit into from

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Mar 19, 2020

which virtualenvwrapper.sh fails on Windows. I propose we remove it from the Makefile command. This means that CCDS assumes a user has virtualenvwrapper set up properly in their shell startup configuration.

@omri374
Copy link
Contributor

omri374 commented May 12, 2020

which is a unix command. In windows the same command is where. Maybe this can help? https://gist.github.com/sighingnow/deee806603ec9274fd47

@pjbull
Copy link
Member

pjbull commented May 12, 2020

which is a unix command. In windows the same command is where. Maybe this can help? https://gist.github.com/sighingnow/deee806603ec9274fd47

Pretty sure that the Bash task on Azure Pipelines will run our code in a bash-like environment across all operating systems so that shouldn't be the issue
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/utility/bash?view=azure-devops

@pjbull
Copy link
Member

pjbull commented Jul 14, 2020

Closing this since it was fixed in #217

@pjbull pjbull closed this Jul 14, 2020
@pjbull pjbull deleted the virtualenvwrapper branch July 14, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants