Add conda-forge instructions for mac #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://cyfi-pr-134.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cmc94vi1hbls739cfnag. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 12 12
Lines 863 863
=====================================
Hits 648 648
Misses 215 215 |
jayqi
requested changes
Jan 6, 2024
jayqi
reviewed
Jan 6, 2024
ejm714
force-pushed
the
114-mac-install
branch
from
df221d1 to
cb10e82
Compare
|
Integrated your feedback @jayqi. It felt like overkill to have the note at the top of the "Install" section and then another note about it three lines down next to the conda-forge install, so now it's just in one clearly visible note at the top of the install section, which includes a link to the issue. The markdown pages use an admonition box (without a header b/c the default for this style is way too loud) and the github README uses the fancy blockquote. |
jayqi
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to LightGBM installation issues on mac, we created a conda-forge feedstock of cyfi. Now that that exists, this PR updates the installation instructions for mac users.
Closes #114