Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DDPPlugin to DDPStrategy #244

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Change DDPPlugin to DDPStrategy #244

merged 3 commits into from
Nov 1, 2022

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented Nov 1, 2022

DDPPlugin was deprecated in pytorch lightning 1.8 which came out today. Replace with supported DDPStrategy. We don't pin PTL, so we are subject to deprecated code in new releases.

Bonus fix:

  • address checkpoint warning
2022-11-01 19:42:05.757 | INFO     | zamba.models.model_manager:train_model:331 - Calculating metrics on validation set.
/usr/local/lib/python3.8/dist-packages/pytorch_lightning/trainer/connectors/checkpoint_connector.py:129: UserWarning: `.validate(ckpt_path=None)` was called without a model. The best model of the previous `fit` call will be used. You can pass `.validate(ckpt_path='best')` to use the best model or `.validate(ckpt_path='last')` to use the last model. If you pass a value, this warning will be silenced.

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for silly-keller-664934 ready!

Name Link
🔨 Latest commit 12ddfe5
🔍 Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/636178b9eebc9f0009922f25
😎 Deploy Preview https://deploy-preview-244--silly-keller-664934.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ejm714 ejm714 requested a review from pjbull November 1, 2022 19:31
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #244 (12ddfe5) into master (bb89011) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #244   +/-   ##
======================================
  Coverage    87.0%   87.0%           
======================================
  Files          28      28           
  Lines        1962    1962           
======================================
  Hits         1707    1707           
  Misses        255     255           
Impacted Files Coverage Δ
zamba/models/model_manager.py 84.3% <100.0%> (ø)
zamba/pytorch_lightning/utils.py 97.4% <100.0%> (ø)

@ejm714 ejm714 merged commit 94a2297 into master Nov 1, 2022
@ejm714 ejm714 deleted the ddp-fix branch November 1, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants