-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uv for CI #311
Use uv for CI #311
Conversation
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think densepose fails to install because they do a build-time check of whether torch is installed, which doesn't work with modern standard of isolated builds. It looks like uv doesn't currently support installing without build isolation: astral-sh/uv#1715 (The discussion in the thread is also a good summary explaining the history and the why of packages behaving like densepose.) |
@ejm714 I just thought of a possible gotcha in how uv and setup-python-uv-action is set up. It's possible that the virtual environment created by setup-python-uv-action doesn't have pip installed in it, and so when you run |
uv 0.1.16, released yesterday, now supports https://github.com/astral-sh/uv/releases/tag/0.1.16 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
======================================
Coverage 87.6% 87.6%
======================================
Files 26 26
Lines 2178 2178
======================================
Hits 1908 1908
Misses 270 270 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for tackling!
Swaps in drivendataorg/setup-python-uv-action and installs our dependencies with uv (without caching).
Closes #312