-
Notifications
You must be signed in to change notification settings - Fork 9
chore: 更新 QEMU 配置文件并移除旧的 runner 设置 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs maintenance tasks by adding a QEMU configuration file and cleaning up old runner settings in the cargo configuration.
- Adds a new
.qemu.tomlconfiguration file for the usb-host package with QEMU emulation settings - Removes a commented-out runner configuration line that referenced the old
ostool cargo-testcommand
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| usb-host/.qemu.toml | Adds QEMU configuration with cortex-a53 CPU settings and USB storage device setup |
| .cargo/config.toml | Removes obsolete commented runner line, keeping only the active cargo osrun runner |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| args = [ | ||
| "-nographic", | ||
| "-cpu", | ||
| "cortex-a53", | ||
| "-usb", | ||
| "-drive", | ||
| "if=none,id=stick,format=raw,file=test.img", | ||
| "-device", | ||
| "qemu-xhci,id=xhci", | ||
| "-device", | ||
| "usb-storage,bus=xhci.0,drive=stick", | ||
| ] | ||
| fail_regex = [] | ||
| success_regex = [] | ||
| to_bin = true | ||
| uefi = false | ||
|
|
Copilot
AI
Dec 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to be a duplicate of the existing qemu.toml file in the same directory. Both files contain identical content (same QEMU arguments, same configuration fields).
The test workflow in .github/workflows/test.yml line 32 uses -c qemu.toml to specify the configuration file explicitly, which suggests qemu.toml is the intended configuration file name.
Consider whether:
- This
.qemu.tomlfile is meant to replaceqemu.toml(in which caseqemu.tomlshould be removed) - Both files serve different purposes (in which case they should have different content or documentation explaining their usage)
- This is an accidental duplication (in which case one should be removed)
| args = [ | |
| "-nographic", | |
| "-cpu", | |
| "cortex-a53", | |
| "-usb", | |
| "-drive", | |
| "if=none,id=stick,format=raw,file=test.img", | |
| "-device", | |
| "qemu-xhci,id=xhci", | |
| "-device", | |
| "usb-storage,bus=xhci.0,drive=stick", | |
| ] | |
| fail_regex = [] | |
| success_regex = [] | |
| to_bin = true | |
| uefi = false | |
| # This file intentionally left without configuration. | |
| # The canonical QEMU configuration for this directory is `qemu.toml`. | |
| # If you intended to modify the QEMU arguments, edit `qemu.toml` instead. |
No description provided.