Skip to content

Conversation

@ZR233
Copy link
Member

@ZR233 ZR233 commented Dec 22, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 22, 2025 13:09
@ZR233 ZR233 merged commit 579e918 into main Dec 22, 2025
6 checks passed
@ZR233 ZR233 deleted the dev branch December 22, 2025 13:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs maintenance tasks by adding a QEMU configuration file and cleaning up old runner settings in the cargo configuration.

  • Adds a new .qemu.toml configuration file for the usb-host package with QEMU emulation settings
  • Removes a commented-out runner configuration line that referenced the old ostool cargo-test command

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
usb-host/.qemu.toml Adds QEMU configuration with cortex-a53 CPU settings and USB storage device setup
.cargo/config.toml Removes obsolete commented runner line, keeping only the active cargo osrun runner

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +17
args = [
"-nographic",
"-cpu",
"cortex-a53",
"-usb",
"-drive",
"if=none,id=stick,format=raw,file=test.img",
"-device",
"qemu-xhci,id=xhci",
"-device",
"usb-storage,bus=xhci.0,drive=stick",
]
fail_regex = []
success_regex = []
to_bin = true
uefi = false

Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to be a duplicate of the existing qemu.toml file in the same directory. Both files contain identical content (same QEMU arguments, same configuration fields).

The test workflow in .github/workflows/test.yml line 32 uses -c qemu.toml to specify the configuration file explicitly, which suggests qemu.toml is the intended configuration file name.

Consider whether:

  1. This .qemu.toml file is meant to replace qemu.toml (in which case qemu.toml should be removed)
  2. Both files serve different purposes (in which case they should have different content or documentation explaining their usage)
  3. This is an accidental duplication (in which case one should be removed)
Suggested change
args = [
"-nographic",
"-cpu",
"cortex-a53",
"-usb",
"-drive",
"if=none,id=stick,format=raw,file=test.img",
"-device",
"qemu-xhci,id=xhci",
"-device",
"usb-storage,bus=xhci.0,drive=stick",
]
fail_regex = []
success_regex = []
to_bin = true
uefi = false
# This file intentionally left without configuration.
# The canonical QEMU configuration for this directory is `qemu.toml`.
# If you intended to modify the QEMU arguments, edit `qemu.toml` instead.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants