refactor: cleanup unused code and simplify conditional logic #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ZR233
commented
Dec 18, 2025
ZR233
commented
- Remove unused schema generation code from QEMU module
- Fix function pointer usage in build module normalization
- Simplify conditional logic in U-Boot TFTP server check
- Remove unused imports and dead code
- Bump version to 0.8.5
- Remove unused schema generation code from QEMU module - Fix function pointer usage in build module normalization - Simplify conditional logic in U-Boot TFTP server check - Remove unused imports and dead code - Bump version to 0.8.5
There was a problem hiding this comment.
Pull request overview
This PR performs code cleanup by removing unused schema generation logic, simplifying conditional expressions, and bumping the version to 0.8.5. The changes focus on improving code maintainability without altering functionality.
- Removed unused schema generation code and import from QEMU module
- Simplified nested conditional logic in U-Boot TFTP server check using
if letchain syntax - Updated function pointer usage in build module path normalization
- Version bump from 0.8.4 to 0.8.5
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ostool/src/run/qemu.rs | Removed unused default_schema_by_init import and dead schema generation code, replaced with info log |
| ostool/src/run/uboot.rs | Simplified nested if statements into a single if let chain for TFTP server conditional |
| ostool/src/build/mod.rs | Updated function pointer syntax for path normalization in map calls |
| ostool/Cargo.toml | Bumped package version from 0.8.4 to 0.8.5 |
| Cargo.lock | Updated lockfile to reflect new version 0.8.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .bin_dir | ||
| .as_ref() | ||
| .map(|d| normalize(d)) | ||
| .map(normalize) |
There was a problem hiding this comment.
Inconsistent function pointer syntax: Line 88 uses map(&normalize) while line 96 uses map(normalize). Both approaches work in Rust, but for consistency within the same code block, they should use the same style. Consider using the same syntax for both calls.
Suggested change
| .map(normalize) | |
| .map(&normalize) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.