Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: boolean mode not working with prepared statements (bettersqlite) #2568

Closed
pekeler opened this issue Jun 28, 2024 · 6 comments · Fixed by #2759
Closed

[BUG]: boolean mode not working with prepared statements (bettersqlite) #2568

pekeler opened this issue Jun 28, 2024 · 6 comments · Fixed by #2759
Labels
bug Something isn't working

Comments

@pekeler
Copy link

pekeler commented Jun 28, 2024

What version of drizzle-orm are you using?

0.31.2

What version of drizzle-kit are you using?

No response

Describe the Bug

Boolean columns always get set to 1 when using a prepared statement. It's working fine when not using a prepared statement.

Simple index.js to reproduce:

import Database from 'better-sqlite3'
import { drizzle } from 'drizzle-orm/better-sqlite3'
import { sql } from 'drizzle-orm'
import { sqliteTable, integer } from 'drizzle-orm/sqlite-core'

const sqlite = new Database('data.sqlite', { verbose: console.log })

sqlite.exec(
  `CREATE TABLE foos (\
 id INTEGER PRIMARY KEY,\
 b1 INTEGER NOT NULL,\
 b2 INTEGER NOT NULL\)`
)

const drizzleDB = drizzle(sqlite)

const foos = sqliteTable('foos', {
  id: integer('id').notNull().primaryKey(),
  b1: integer('b1', { mode: 'boolean' }).notNull(),
  b2: integer('b2').notNull(),
})

drizzleDB.insert(foos).values({ id: 1, b1: false, b2: 0 }).run() // correct
drizzleDB.insert(foos).values({ id: 2, b1: true,  b2: 1 }).run() // correct

const prep = drizzleDB
  .insert(foos)
  .values({
    id: sql.placeholder('id'),
    b1: sql.placeholder('b1'),
    b2: sql.placeholder('b2'),
  })
  .prepare()

prep.run({ id: 3, b1: false, b2: 0 }) // wrong
prep.run({ id: 4, b1: true,  b2: 1 }) // correct

Expected behavior

CREATE TABLE foos ( id INTEGER PRIMARY KEY, b1 INTEGER NOT NULL, b2 INTEGER NOT NULL)
insert into "foos" ("id", "b1", "b2") values (1.0, 0.0, 0.0)
insert into "foos" ("id", "b1", "b2") values (2.0, 1.0, 1.0)
insert into "foos" ("id", "b1", "b2") values (3.0, 0.0, 0.0)
insert into "foos" ("id", "b1", "b2") values (4.0, 1.0, 1.0)

Environment & setup

MacOS 14.5
better-sqlite3 11.0.0
SQLite 3.43.2

@pekeler pekeler added the bug Something isn't working label Jun 28, 2024
@pekeler
Copy link
Author

pekeler commented Jul 3, 2024

I just contributed to the bounty on this issue.

Each contribution to this bounty has an expiry time and will be auto-refunded to the contributor if the issue is not solved before then.

Current bounty reward

To make this a public bounty or have a reward split, the maintainer can reply to this comment.

@AndriiSherman
Copy link
Member

Working on this one, already found an issue

@veloii
Copy link
Contributor

veloii commented Aug 7, 2024

Hey, I've already got a fork with it working. Would you like me to submit a PR?

@veloii
Copy link
Contributor

veloii commented Aug 7, 2024

@AndriiSherman The fork is here if you want to use my implementation. https://github.com/veloii/drizzle-orm/tree/main. All good if you've already got it working!

@AndriiSherman
Copy link
Member

@veloii would be awesome if you can make a PR for it, if everything is good - I'll merge

@AndriiSherman
Copy link
Member

Should be fixed in drizzle-orm0.33.0
Please check release notes before updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants