-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix placeholders being mapped to it's driver value instead of the value #2759
Conversation
Thanks a lot! |
cc @veloii |
Sorry - I was out. I'll add the tests in now. How should they be named? |
We can name it like: |
The set method on update doesn't allow placeholders. Is this a type bug or current limitation? |
Oh, I guess it's a limitation, or maybe we can't even use it in updates. We'll need to check. For now, just skip update tests and focus only on inserts |
Sorry for the delay, should all be done now! I was unable to verify the MySQL test locally but I assume the action will test it anyway. |
This fixes #2568. I've also modified the SQLite prepared statement test to include a boolean placeholder.