[AWS] fix: raw sql query not being mapped properly on RDS (#578) #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boian-ivanov could you please sign all commits? So far changes looks good for me, but I need @dankochetov eyes for this one as well |
@AndriiSherman Unfortunately I’m out of the country at the moment and without a laptop to rebase and sign the current commits. If everything’s alright would that be fine to be sorted as is? 🤔 |
dankochetov
previously requested changes
Aug 29, 2023
AndriiSherman
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue for raw sql queries via the
aws-data-apiclient to not be properly mapped to the correct column names. (#578)Test cases have been added, but the typing is still a bit off. As of now this is at least a good enough fix for us as we can cast the proper types, but at least the format is kept as expected.