Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PG] Add missing select functions in with clause #1467

Closed
wants to merge 3 commits into from
Closed

[PG] Add missing select functions in with clause #1467

wants to merge 3 commits into from

Conversation

L-Mario564
Copy link
Collaborator

When using the with clause, the PG dialect for Drizzle would only expose select. This PR makes it so you can also use selectDistinct and selectDistinctOn after the with clause.

Angelelz
Angelelz suggested changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@Angelelz Angelelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests we could implement to validate this addition?

@L-Mario564
Copy link
Collaborator Author

Are there any tests we could implement to validate this addition?

I've added them.

@L-Mario564
Copy link
Collaborator Author

Closed in favor of #1578.

@L-Mario564 L-Mario564 closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angelelz Angelelz Angelelz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Mario564 @Angelelz