[Pg] Add tests for Postgres ->> and -> operators #1560
Conversation
Added tests for the Postgres ->> and -> operators, including a known failing test for the Postgres.js integration. The reason for this test failing is due to the way Postgres.js handles stringified JSON input.
|
If there is a failing test I'm not sure this can be merged. I can work on the underlying issue and if you are ok with it, I can include your code in my PR. I don't think I'll have time to open the PR and have it reviewed before the next minor release but I'll give it a try |
|
The test does not fail the whole test suite, since it is declared using the |
|
Hey @serdnam, since the fix should be merged soon, I guess can you delete the failing part? That way when this is merged we wont have issues. |
|
Sure, I'll delete it. |
|
My apologies, I should have said just delete the word failing, so it's a regular test Edit: what I mean is, the test should stay |
serdnam
force-pushed
the
postgres-json-tests
branch
from
43e0a0e to
16b7485
Compare
|
No worries! I restored the test without the |
This PR adds tests only, related to issue #1511. The tests assert whether the
->and->>operators work after insertingjsonorjsonbvalues into Postgres.The included tests include a failing test for the postgres.js integration, it seems it does not properly handle stringified objects as input to JSON/JSONB columns, I have prepared a demo of this behavior here: https://github.com/serdnam/postgres-js-json-behavior.
I tried my hand at solving it, but I do not know the codebase well enough to know how or where to make a change to fix this (or if the change has to be done on drizzle's side at all, it seems there is a related postgres.js issue porsager/postgres#392)