[Pg] Add insert/update array support in aws-data-api #1911
Merged
+171
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingforjesus
changed the title
|
Created to fix #1912 |
livingforjesus
force-pushed
the
fix-arrayvalue-issue
branch
from
d2d6ce4 to
46bec30
Compare
Merged
dankochetov
force-pushed
the
fix-arrayvalue-issue
branch
from
c737088 to
46bec30
Compare
Currently, trying to insert text[] or any other kind of array fails in data-api This is a workaround for that by manually casting array params.
update Previously, I was doing automatic casting for arrays for insert and not update. Fixed this
mapToDriverValue function Previously, I manually converted array to driver string value. However, after further inspection I realised it was better to use column mapToDriverValue function.
My previous changes in test file broke a couple tests. I've fixed this now
dankochetov
force-pushed
the
fix-arrayvalue-issue
branch
from
46bec30 to
46b4593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in drizzle, if you want to insert or update an array, there is a typing issue like this:
This PR Adds support for for fixing this issue via auto-casting in this situation.
Changes:
getValueFromDataApi