-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] inArray and notInArray accept empty list #2502
[feat] inArray and notInArray accept empty list #2502
Conversation
fc80d21
to
a50ebc3
Compare
@philippdormann You reviewed the same changes back in march of this year in the MR #1664 |
@RemiPeruto @AndriiSherman This PR would actually fix an issue in my project, could you review it please? |
Thanks a lot! It looks great and is ready to merge. However, if you can resolve the conflicts, that would be helpful. I can explain why there are conflicts and what should be done. Previously, all tests were separated by drivers, and now we have a *.common.ts file, for example, tests/pg/pg.common.ts, where all tests for pg are located and will be run in each driver automatically. There is no need to copy tests through all the files |
a50ebc3
to
e1b9978
Compare
@AndriiSherman thanks a lot ! |
e1b9978
to
8f97370
Compare
@AndriiSherman Could you review it please ? It would be nice to have this feature. Like @ThomasAribart said, it will fix some issues in my project. |
@RemiPeruto Could you please format all the files that you changed so they can pass dprint checks? |
I am on it. |
Make inArray and notInArray methods accept an empty list as their second parameter
8f97370
to
fb0868e
Compare
Going to make a few releases today. This one will be included |
close #1295
Make inArray and notInArray methods accept an empty list as their second parameter instead of throwing an error :
the comment referencing the choice of implementation in the thread