Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PG] Improve default value generation for array columns #2756

Merged

Conversation

L-Mario564
Copy link
Collaborator

@L-Mario564 L-Mario564 commented Aug 6, 2024

Addresses #2621, #2709, #2432, #2334, #2224, #1003 & #1564.

This PR aims to improve the way Drizzle Kit generates the default value for array columns, successfully converting a TS array into a string that represents it in SQL.

@AndriiSherman
Copy link
Member

Thanks a lot, @L-Mario564! To ensure that all the tickets from the list are closed, please add test cases for all the issues

  • for example #2709 has a problem with the default in enums, but I can't see a test case for the enum type
  • for #1003 it's uuid type
  • #1564 also has a enum in example

@AndriiSherman AndriiSherman changed the base branch from main to beta August 7, 2024 10:48
@AndriiSherman AndriiSherman merged commit 505c62f into drizzle-team:beta Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants