-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORM minor enhancements and bugfixes #3649
Open
L-Mario564
wants to merge
23
commits into
drizzle-team:beta
Choose a base branch
from
L-Mario564:orm-improvements
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address many smaller issues.
[BUG]: #1826
Expressions like
isNull
,eq
, etc. now outputSQL<boolean>
instead ofSQL<unknown>
.[BUG]:
sqliteTable
3rd parameter array type error #3326SQLite and MySQL now match PG's array syntax for declaring extra config.
[BUG]: Column name not being returned as snake_case #3094
Introduced a new method to all dialect columns:
nameWithCasing
. The avoid breaking the existingname
property, this method was introduced to add further flexibility with handling casing in your queries. This can be used as such:[BUG]: inserting json does not work when using
sql
template string #3171Inserting JSON using the
sql
operator now works as expected when using the postgres.js driver.[BUG]: postgres insert and generatedAlwaysAsIdentity tries to insert null value #3576
Fixed the condition that filters out generated columns. These shouldn't be included anymore, as expected.
[BUG]: "Insert into ... select" expects all columns #3608
This has been fixed.
insert into ... select
has been internally tweaked to handle generated columns and optional fields.[BUG]: PgInsertValue regression in 0.36.4 #3620
PgInsertValue
now outputs the correct type.[BUG]: Incorrect TypeScript inference for SQLite Blob column builder #1064
The return type definition now matches the runtime value.
[BUG]: Incorrect type inference with multidimensional array field PostgreSQL #1028
[BUG]: column type
json
array is returningunknown[]
#2913Arrays now handle custom type definitions rather than just resolving to
unknown[]
.[BUG]: Cannot use SQL.Aliased from SubQuery in GroupBy #3632
This was only an issue with SQLite. Now fixed.
[FEATURE]: Nullable type inference with .mapWith() #571
mapWith
method ignored the column's nullability if a column was passed as an argument. This has been fixed.[BUG]: Problem with the transaction #952
Could not reproduce this issue; however, I changed the SQL generation of transaction config in MySQL so it uses
sql.raw
instead ofsql
. This should avoid the SQL statement to begin the transaction from ever being parameterized.[FEATURE]: column.as("alias") method #2391
You can now very easily alias a column: