Fix drizzle-zod and drizzle-typebox mapping refinements incorrectly
#3737
+329
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Mario564
changed the title
drizzle-zod mapping refinements incorrectlydrizzle-zod and drizzle-typebox mapping refinements incorrectly
grmkris
approved these changes
Dec 10, 2024
|
@L-Mario564 let's add tests for all such cases, to make sure we won't hit it in the future |
|
@L-Mario564 Do you know if this PR will fix #3732 and #3747? |
I'm not sure, and it's difficult to verify such since the bug only happens after building it. If it's not fixed by removing the internal JSDoc comments (done in this PR) then we likely need to just expose internal types, which we'd do in a separate PR soon. |
|
I added some example code on #3734. It may be helpful for reproduction and testing, assuming it's the same issue mentioned by OP. |
|
Managed to fix #3751 for drizzle-valibot. |
This was referenced Dec 18, 2024
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3735, #3756, #3751 & #3734.
Title. Also removed some unnecessary
@internalJSDoc comments.