Enable tracing #4195
Open
Enable tracing #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-pedersen
force-pushed
the
enable-tracing
branch
from
afb717e to
b198388
Compare
daniel-pedersen
force-pushed
the
enable-tracing
branch
from
b198388 to
c41c614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables otel tracing, which is already implemented.
The tracing seems to have been disabled due to incompatibility with top-level await for certain bundlers. This issue was resolved with an IIFE.
Additionaly, a bug was fixed where the finally clause runs before the promise resolves due to the wrapper retuning early. Hence the async/await wrapping on the span.
We've run this code as a patch in production for a few weeks and it works well. Though only tested for
postgres-js.Let me know if any tests are needed, or how I can help to get this feature enabled.