Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added from() to all inline examples #507

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Conversation

ivoilic
Copy link
Contributor

@ivoilic ivoilic commented Apr 23, 2023

It appears that all the inline examples in expressions/conditions used an incorrect or maybe outdated? syntax. I've changed all instances of select(cars) to select().from(cars) to match the examples in the main documentation.

Copy link
Contributor

@dankochetov dankochetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@dankochetov dankochetov merged commit dbf9508 into drizzle-team:main Apr 24, 2023
@ivoilic ivoilic deleted the patch-1 branch April 24, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants