Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sideEffects: false to package.json #515

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Apr 24, 2023

This adds the key "sideEffects": false to the package.json of drizzle-orm. The intent is that, when using Webpack, parcel, vite, or rollup, the sideEffects property allows the bundler to tree-shake unused parts of the module. Also, when using Remix, this key allows the automatic server-code extraction to omit drizzle-orm from bundles for the client.

Copy link
Contributor

@dankochetov dankochetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Didn't know about that. Thanks!

@dankochetov dankochetov merged commit 8f4bd15 into drizzle-team:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants