[SQLite] Fix upsert targeting composite keys #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the target consisted of multiple columns, they were wrapped in two pairs for parentheses, which was invalid SQL. Also a target is required with "DO UPDATE" upserts now as per the spec (cp. https://www.sqlite.org/lang_UPSERT.html).
|
Anything needed to get this merged? @AndriiSherman? 🤔 |
|
@hirvesh no, we just didn't have time to clean all PRs while releasing One of the next priorities for @dankochetov would be to review and clean up all PRs, merging everything that appears to be in good condition So no worries, it all soon should be fixed |
|
Thank you Andrii 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #518.
If the target consisted of multiple columns, they were wrapped in two pairs for parentheses, which was invalid SQL. Thanks @hirvesh for identifying the root cause of the failed SQL queries.
Also a target is required with "DO UPDATE" upserts now as per the spec (cp. https://www.sqlite.org/lang_UPSERT.html). Should not break existing code bases since queries without a target would have failed.