Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joins docs typo #522

Merged
merged 1 commit into from
Jun 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/feature-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ labels: ["enhancement"]
body:
- type: textarea
attributes:
label: Describe want to want
description: What the problrem is? What to want to change or add?
label: Describe what you want
description: What is the problem? What do you want to change or add?
validations:
required: true
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ Example
[Pg] Add PostGIS extension support
```

2. PR should contain detailed description with everyting, that was changed
2. PR should contain detailed description with everything, that was changed

3. Each PR should contain
- Tests on feature, that was created;
Expand Down
2 changes: 1 addition & 1 deletion drizzle-orm/src/mysql-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ const users = mysqlTable('users', {
cityId: int('city_id').references(() => cities.id),
});

const result = db.select().from(cities).leftJoin(users, eq(cities2.id, users2.cityId));
const result = db.select().from(cities).leftJoin(users, eq(cities.id, users.cityId));
```

#### Many-to-many
Expand Down
2 changes: 1 addition & 1 deletion drizzle-orm/src/pg-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ const users = pgTable('users', {
cityId: integer('city_id').references(() => cities.id),
});

const result = db.select().from(cities).leftJoin(users, eq(cities2.id, users2.cityId));
const result = db.select().from(cities).leftJoin(users, eq(cities.id, users.cityId));
```

#### Many-to-many
Expand Down
4 changes: 2 additions & 2 deletions drizzle-orm/src/sqlite-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export const countries = sqliteTable('countries', {
id: integer('id').primaryKey(),
name: text('name'),
population: integer('population'),
capital: integer('capital').references(() => cities.id, { onUpdate: 'cascade', onDelete: 'cascade' })
capital: integer('capital').references(() => cities.id, { onUpdate: 'cascade', onDelete: 'cascade' })
}, (countries) => ({
nameIdx: index('name_idx').on(countries.name), // one column
namePopulationIdx: index('name_population_idx').on(countries.name, countries.population), // multiple columns
Expand Down Expand Up @@ -617,7 +617,7 @@ const users = sqliteTable('users', {

const db = drizzle(sqlite);

const result = db.select().from(cities).leftJoin(users, eq(cities2.id, users2.cityId)).all();
const result = db.select().from(cities).leftJoin(users, eq(cities.id, users.cityId)).all();
```

### Many-to-many
Expand Down