Suggestions #1
Merged
Suggestions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
commented
Mar 19, 2024
| @@ -76,7 +76,7 @@ | |||
| import static org.elasticsearch.xpack.core.ClientHelper.executeAsyncWithOrigin; | |||
| import static org.elasticsearch.xpack.ml.utils.InferenceProcessorInfoExtractor.pipelineIdsByResource; | |||
|
|
|||
| public class TransportGetTrainedModelsStatsAction extends HandledTransportAction< | |||
| public class TransportGetTrainedModelsStatsAction extends TransportAction< | |||
There was a problem hiding this comment.
No need to be a HandledTransportAction, this action is only ever invoked on the local node AFAICT.
Comment on lines
+112
to
+113
| // workaround for https://github.com/elastic/elasticsearch/issues/97916 - TODO remove this when we can | ||
| executor.execute(ActionRunnable.wrap(listener, l -> doExecuteForked(task, request, l))); |
There was a problem hiding this comment.
fork the whole thing onto executor first
| l | ||
| ); | ||
| }) | ||
| .andThenAccept(tuple -> responseBuilder.setExpandedModelIdsWithAliases(tuple.v2()).setTotalModelCount(tuple.v1())) |
There was a problem hiding this comment.
suggest using andThenAccept to split out the handling of the previous step's result from the initiation of the next steps.
| deploymentStats.getStats() | ||
| .results() | ||
| SubscribableListener | ||
|
|
There was a problem hiding this comment.
More blank lines makes for better formatting throughout.
|
Thanks @DaveCTurner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.